fix: The NFTPortal should declare that the IPortal interface is implemented #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingning-aspecta
requested review from
alainncls,
fdemiramon,
satyajeetkolhapure,
orbmis and
0xEillo
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #318 +/- ##
==========================================
+ Coverage 91.51% 91.55% +0.03%
==========================================
Files 13 13
Lines 224 225 +1
Branches 53 53
==========================================
+ Hits 205 206 +1
Misses 10 10
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alainncls
approved these changes
Oct 24, 2023
|
@dingning-aspecta can you just run the prettier job to remove the extra line below the imports? |
orbmis
approved these changes
Oct 24, 2023
auto-merge was automatically disabled
October 25, 2023 02:32
Head branch was pushed to by a user without write access
Of course, it has been changed. please check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related ticket
Fixes #310
Type of change
Check list