Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to have an example ERC-1271 module #314

Merged
merged 9 commits into from
Oct 23, 2023
Merged

feat: As a user, I want to have an example ERC-1271 module #314

merged 9 commits into from
Oct 23, 2023

Conversation

Builddddder
Copy link
Contributor

What does this PR do?

Related ticket

Fixes #247

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls changed the title Add erc 1271 module implementation feat: As a user, I want to have an example ERC-1271 module Oct 23, 2023
@alainncls
Copy link
Collaborator

Hey @Builddddder , that's great! 👍
Can you run pnpm run prettier:write at the root of the project to benefit from a perfect linting?
Also, on the test part of the ERC1271Module, do you think it's possible to cover a bit more code? Or do you see any issue with that?

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #314 (62937f4) into dev (c877819) will decrease coverage by 1.92%.
Report is 2 commits behind head on dev.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##              dev     #314      +/-   ##
==========================================
- Coverage   93.43%   91.51%   -1.92%     
==========================================
  Files          12       13       +1     
  Lines         198      224      +26     
  Branches       46       53       +7     
==========================================
+ Hits          185      205      +20     
- Misses          8       10       +2     
- Partials        5        9       +4     
Files Coverage Δ
contracts/src/examples/modules/ERC1271Module.sol 76.92% <76.92%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Builddddder
Copy link
Contributor Author

@alainncls OK, I am fixing the left problems.

@alainncls alainncls enabled auto-merge (squash) October 23, 2023 17:26
@alainncls alainncls merged commit 4c68daf into Consensys:dev Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want to have an example ERC-1271 module
4 participants