Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to be able to call any method on the PortalRegistry via the SDK #313

Conversation

fksyuan
Copy link
Contributor

@fksyuan fksyuan commented Oct 23, 2023

What does this PR do?

Related ticket

Fixes #204

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #313 (b6d70d9) into dev (01a15b5) will not change coverage.
The diff coverage is n/a.

❗ Current head b6d70d9 differs from pull request most recent head 23bcb96. Consider uploading reports for the commit 23bcb96 to get more accurate results

@@           Coverage Diff           @@
##              dev     #313   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          12       12           
  Lines         198      198           
  Branches       46       46           
=======================================
  Hits          185      185           
  Misses          8        8           
  Partials        5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-be-able-to-call-any-method-on-the-PortalRegistry-via-the-SDK branch from b6d70d9 to 23bcb96 Compare October 23, 2023 13:17
@alainncls alainncls enabled auto-merge (squash) October 23, 2023 13:18
@alainncls alainncls merged commit 8b1edf9 into dev Oct 23, 2023
6 checks passed
@alainncls alainncls deleted the feature/as-a-user-i-want-to-be-able-to-call-any-method-on-the-PortalRegistry-via-the-SDK branch October 23, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want to be able to call any method on the PortalRegistry via the SDK
3 participants