Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to batch create and batch revoke attestations with the SDK #280

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Oct 13, 2023

What does this PR do?

Related ticket

Fixes #170

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #280 (0ffca86) into dev (37a8b45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #280   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files          13       13           
  Lines         197      197           
  Branches       46       46           
=======================================
  Hits          184      184           
  Misses          8        8           
  Partials        5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sdk/src/dataMapper/PortalDataMapper.ts Outdated Show resolved Hide resolved
sdk/src/dataMapper/PortalDataMapper.ts Show resolved Hide resolved
sdk/src/dataMapper/PortalDataMapper.ts Show resolved Hide resolved
@alainncls alainncls self-requested a review October 13, 2023 14:02
@alainncls alainncls merged commit 0964794 into dev Oct 13, 2023
6 checks passed
@alainncls alainncls deleted the feature/as-a-user-i-want-to-batch-create-and-batch-revoke-attestations-with-the-SDK branch October 13, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want to batch create and batch revoke attestations with the SDK
5 participants