Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user i want to get decoded attestation data via the subgraph #229

Conversation

alainncls
Copy link
Collaborator

@alainncls alainncls commented Sep 26, 2023

What does this PR do?

  • Decodes the attestationData field of an newly created Attestation
  • Doesn't decode Tuples (nested schema objects)

Related ticket

Fixes #226

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Sep 26, 2023
@alainncls alainncls changed the title Feature/as a user i want to get decoded attestation data via the subgraph feat: As a user i want to get decoded attestation data via the subgraph Sep 26, 2023
@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-get-decoded-attestation-data-via-the-subgraph branch 3 times, most recently from 683d73e to e59b4b6 Compare September 27, 2023 09:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #229 (d9df90d) into dev (5bac36d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #229   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          11       11           
  Lines         169      169           
  Branches       38       38           
=======================================
  Hits          161      161           
  Misses          6        6           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alainncls alainncls marked this pull request as ready for review September 28, 2023 08:54
@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-get-decoded-attestation-data-via-the-subgraph branch from e59b4b6 to 91be02c Compare September 28, 2023 09:14
@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-get-decoded-attestation-data-via-the-subgraph branch from 91be02c to d9df90d Compare September 28, 2023 12:12
@alainncls alainncls merged commit e475d26 into dev Sep 28, 2023
5 checks passed
@alainncls alainncls deleted the feature/as-a-user-i-want-to-get-decoded-attestation-data-via-the-subgraph branch September 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want to get decoded Attestation data via the subgraph
3 participants