Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: as an attestation consumer, I want to be able to check if an address has an attestation using the ERC-1155 owner method #227

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Sep 26, 2023

What does this PR do?

Related ticket

Fixes #109

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

src/AttestationRegistry.sol Outdated Show resolved Hide resolved
src/AttestationRegistry.sol Outdated Show resolved Hide resolved
src/AttestationRegistry.sol Outdated Show resolved Hide resolved
src/AttestationRegistry.sol Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #227 (755ded0) into dev (8e0efd6) will decrease coverage by 2.39%.
Report is 3 commits behind head on dev.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##              dev     #227      +/-   ##
==========================================
- Coverage   96.27%   93.88%   -2.39%     
==========================================
  Files          10       11       +1     
  Lines         161      180      +19     
  Branches       38       41       +3     
==========================================
+ Hits          155      169      +14     
- Misses          4        7       +3     
- Partials        2        4       +2     
Files Coverage Δ
src/AttestationRegistry.sol 92.85% <72.72%> (-4.93%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alainncls alainncls force-pushed the feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method branch from 755ded0 to c60560e Compare September 26, 2023 13:08
@alainncls alainncls enabled auto-merge (squash) September 26, 2023 13:08
@alainncls alainncls merged commit 0362d40 into dev Sep 26, 2023
@alainncls alainncls deleted the feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method branch September 26, 2023 13:10
@satyajeetkolhapure satyajeetkolhapure restored the feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method branch September 28, 2023 09:17
satyajeetkolhapure added a commit that referenced this pull request Sep 28, 2023
…if an address has an attestation using the ERC-1155 owner method (#227)"

This reverts commit 0362d40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants