-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: as an attestation consumer, I want to be able to check if an address has an attestation using the ERC-1155 owner method #227
Merged
alainncls
merged 5 commits into
dev
from
feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method
Sep 26, 2023
Merged
feat: as an attestation consumer, I want to be able to check if an address has an attestation using the ERC-1155 owner method #227
alainncls
merged 5 commits into
dev
from
feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyajeetkolhapure
requested review from
alainncls,
fdemiramon,
orbmis and
0xEillo
as code owners
September 26, 2023 11:39
alainncls
requested changes
Sep 26, 2023
Codecov Report
@@ Coverage Diff @@
## dev #227 +/- ##
==========================================
- Coverage 96.27% 93.88% -2.39%
==========================================
Files 10 11 +1
Lines 161 180 +19
Branches 38 41 +3
==========================================
+ Hits 155 169 +14
- Misses 4 7 +3
- Partials 2 4 +2
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alainncls
approved these changes
Sep 26, 2023
alainncls
force-pushed
the
feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method
branch
from
September 26, 2023 13:08
755ded0
to
c60560e
Compare
alainncls
deleted the
feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method
branch
September 26, 2023 13:10
satyajeetkolhapure
restored the
feature/as-an-attestation-consumer-i-want-to-be-able-to-check-if-an-address-has-an-attestation-using-the-erc-1155-owner-method
branch
September 28, 2023 09:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related ticket
Fixes #109
Type of change
Check list