Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup and improvements #222

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

  • Unifies tests names
  • Adds a lot of NatSpec comments on smart contracts
  • Eliminates most of the linting warnings

Related ticket

Fixes #94

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Sep 22, 2023
@alainncls alainncls force-pushed the chore/cleanup-and-improvements branch 2 times, most recently from b56d72f to 70ee9f9 Compare September 22, 2023 10:12
@alainncls alainncls force-pushed the chore/cleanup-and-improvements branch from 70ee9f9 to c76fb27 Compare September 22, 2023 12:31
@alainncls alainncls enabled auto-merge (squash) September 22, 2023 12:32
@codecov-commenter
Copy link

Codecov Report

Merging #222 (c76fb27) into dev (75941ae) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #222      +/-   ##
==========================================
- Coverage   95.85%   95.26%   -0.60%     
==========================================
  Files          11       11              
  Lines         169      169              
  Branches       38       38              
==========================================
- Hits          162      161       -1     
- Misses          5        6       +1     
  Partials        2        2              
Files Changed Coverage Δ
src/AttestationRegistry.sol 97.77% <ø> (ø)
src/ModuleRegistry.sol 95.23% <ø> (ø)
src/PortalRegistry.sol 95.83% <ø> (ø)
src/Router.sol 92.30% <ø> (-7.70%) ⬇️
src/SchemaRegistry.sol 94.44% <ø> (ø)
src/example/EASPortal.sol 92.30% <ø> (ø)
src/example/MsgSenderModule.sol 100.00% <ø> (ø)
src/example/PayableModule.sol 100.00% <ø> (ø)
src/interface/AbstractModule.sol 100.00% <ø> (ø)
src/interface/AbstractPortal.sol 95.23% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alainncls alainncls merged commit c5c0817 into dev Sep 22, 2023
@alainncls alainncls deleted the chore/cleanup-and-improvements branch September 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Cleanup and improvements
4 participants