Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As an attestation issuer, I would like to remain compatible with the ERC-721 standard #220

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Sep 20, 2023

What does this PR do?

Related ticket

Fixes #137

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@satyajeetkolhapure satyajeetkolhapure self-assigned this Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #220 (6ac63a1) into dev (8e0efd6) will decrease coverage by 0.40%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##              dev     #220      +/-   ##
==========================================
- Coverage   96.27%   95.88%   -0.40%     
==========================================
  Files          10       11       +1     
  Lines         161      170       +9     
  Branches       38       38              
==========================================
+ Hits          155      163       +8     
- Misses          4        5       +1     
  Partials        2        2              
Files Changed Coverage Δ
src/example/NFTPortal.sol 88.88% <88.88%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@satyajeetkolhapure satyajeetkolhapure force-pushed the feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard branch from 3223055 to 8885949 Compare September 21, 2023 14:20
…-compatible-with-the-erc-721-standard' of https://github.com/Consensys/linea-attestation-registry into feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
@satyajeetkolhapure satyajeetkolhapure marked this pull request as ready for review September 21, 2023 14:21
test/example/NFTPortal.t.sol Outdated Show resolved Hide resolved
test/example/NFTPortal.t.sol Outdated Show resolved Hide resolved
satyajeetkolhapure and others added 3 commits September 22, 2023 11:50
…-compatible-with-the-erc-721-standard' of https://github.com/Consensys/linea-attestation-registry into feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
src/example/NFTPortal.sol Outdated Show resolved Hide resolved
src/example/NFTPortal.sol Outdated Show resolved Hide resolved
test/example/NFTPortal.t.sol Outdated Show resolved Hide resolved
test/example/NFTPortal.t.sol Outdated Show resolved Hide resolved
@alainncls alainncls enabled auto-merge (squash) September 22, 2023 12:15
@alainncls alainncls self-requested a review September 22, 2023 12:15
@alainncls alainncls force-pushed the feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard branch from 40dae3b to 0fd5bfb Compare September 22, 2023 12:19
@alainncls alainncls merged commit 578b423 into dev Sep 22, 2023
5 checks passed
@alainncls alainncls deleted the feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard branch September 22, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As an attestation issuer, I would like to remain compatible with the ERC-721 standard
4 participants