-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: As an attestation issuer, I would like to remain compatible with the ERC-721 standard #220
Merged
alainncls
merged 16 commits into
dev
from
feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
Sep 22, 2023
Merged
feat: As an attestation issuer, I would like to remain compatible with the ERC-721 standard #220
alainncls
merged 16 commits into
dev
from
feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #220 +/- ##
==========================================
- Coverage 96.27% 95.88% -0.40%
==========================================
Files 10 11 +1
Lines 161 170 +9
Branches 38 38
==========================================
+ Hits 155 163 +8
- Misses 4 5 +1
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
satyajeetkolhapure
force-pushed
the
feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
branch
from
September 21, 2023 14:20
3223055
to
8885949
Compare
…-compatible-with-the-erc-721-standard' of https://github.com/Consensys/linea-attestation-registry into feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
satyajeetkolhapure
requested review from
alainncls,
fdemiramon,
orbmis and
0xEillo
as code owners
September 21, 2023 14:21
alainncls
requested changes
Sep 22, 2023
Co-authored-by: Alain Nicolas <[email protected]>
…-compatible-with-the-erc-721-standard' of https://github.com/Consensys/linea-attestation-registry into feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
alainncls
requested changes
Sep 22, 2023
alainncls
requested changes
Sep 22, 2023
alainncls
approved these changes
Sep 22, 2023
alainncls
force-pushed
the
feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
branch
from
September 22, 2023 12:19
40dae3b
to
0fd5bfb
Compare
alainncls
deleted the
feature/as-an-attestation-issuer-i-would-like-to-remain-compatible-with-the-erc-721-standard
branch
September 22, 2023 12:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related ticket
Fixes #137
Type of change
Check list