New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE - chore: Cleanup and improvements (underscore on private/internal fields) #219

Closed

alainncls wants to merge 1 commit into dev from chore/cleanup-and-improvements-underscore

Collaborator

alainncls commented Sep 20, 2023

DO NOT MERGE


          chore: Cleanup and improvements (underscore on private/internal fields)

9c06a82

alainncls self-assigned this

Collaborator Author

alainncls commented Sep 22, 2023

Won't do because it breaks upgradeability. without bringing a lot of value

alainncls closed this

alainncls mentioned this pull request

[TASK] Cleanup and improvements #94

Closed

7 tasks

alainncls deleted the chore/cleanup-and-improvements-underscore branch

September 27, 2023 14:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

satyajeetkolhapure Awaiting requested review from satyajeetkolhapure satyajeetkolhapure will be requested when the pull request is marked ready for review satyajeetkolhapure is a code owner

orbmis Awaiting requested review from orbmis orbmis will be requested when the pull request is marked ready for review orbmis is a code owner

arthur-remy Awaiting requested review from arthur-remy arthur-remy will be requested when the pull request is marked ready for review arthur-remy is a code owner

Labels

None yet