Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Portal should not be initializable/upgradeable #199

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Prevents the portals from being initializable or upgradeable

Related ticket

Fixes #198

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #199 (32be69a) into dev (56d5ece) will decrease coverage by 0.14%.
Report is 1 commits behind head on dev.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
- Coverage   96.42%   96.29%   -0.14%     
==========================================
  Files          10       10              
  Lines         168      162       -6     
  Branches       40       40              
==========================================
- Hits          162      156       -6     
  Misses          4        4              
  Partials        2        2              
Files Changed Coverage Δ
src/example/EASPortal.sol 92.85% <ø> (ø)
src/PortalRegistry.sol 95.83% <100.00%> (-0.17%) ⬇️
src/interface/AbstractPortal.sol 95.23% <100.00%> (-0.92%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alainncls alainncls force-pushed the fix/portal-should-not-be-initializableupgradeable branch from e0c7369 to 32be69a Compare September 18, 2023 12:36
@alainncls alainncls merged commit cbd2142 into dev Sep 19, 2023
@alainncls alainncls deleted the fix/portal-should-not-be-initializableupgradeable branch September 19, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Portal should not be initializable/upgradeable
3 participants