Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As an Issuer, I want my Module(s) to return a bool when run #195

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Sep 14, 2023

What does this PR do?

Related ticket

Fixes #182

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #195 (2a2ddf1) into dev (4aac392) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #195      +/-   ##
==========================================
+ Coverage   96.42%   96.59%   +0.16%     
==========================================
  Files          10       10              
  Lines         168      176       +8     
  Branches       40       40              
==========================================
+ Hits          162      170       +8     
  Misses          4        4              
  Partials        2        2              
Files Changed Coverage Δ
src/interface/AbstractModule.sol 100.00% <ø> (ø)
src/ModuleRegistry.sol 96.29% <100.00%> (+1.05%) ⬆️
src/example/MsgSenderModule.sol 100.00% <100.00%> (ø)
src/example/PayableModule.sol 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alainncls alainncls marked this pull request as draft September 15, 2023 13:06
@satyajeetkolhapure satyajeetkolhapure marked this pull request as ready for review September 18, 2023 08:58
@alainncls alainncls marked this pull request as draft September 18, 2023 09:01
@alainncls
Copy link
Collaborator

Closing for now, but the branch remains protected

@alainncls alainncls closed this Oct 12, 2023
@alainncls alainncls deleted the feature/as-an-issuer-i-want-my-modules-to-return-a-bool-when-run branch November 9, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As an Issuer, I want my Module(s) to return a bool when run
5 participants