Skip to content

Commit

Permalink
fix: When bulk running modules, loop over attestations payloads and n…
Browse files Browse the repository at this point in the history
…ot modules (#218)
  • Loading branch information
alainncls authored Sep 20, 2023
1 parent fd00e0b commit 6b1d978
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/ModuleRegistry.sol
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,10 @@ contract ModuleRegistry is OwnableUpgradeable {
}
}

/** Execute the run method for all given Modules that are registered
/** Execute the modules validation for all attestations payloads for all given Modules that are registered
* @param modulesAddresses the addresses of the registered modules
* @param attestationsPayloads the payloads to attest
* @param validationPayloads the payloads to check for each module
* @dev check if modules are registered and execute run method for each module
* @dev NOTE: Currently the bulk run modules does not handle payable modules
* a default value of 0 is used.
*/
Expand All @@ -147,7 +146,7 @@ contract ModuleRegistry is OwnableUpgradeable {
AttestationPayload[] memory attestationsPayloads,
bytes[][] memory validationPayloads
) public {
for (uint32 i = 0; i < modulesAddresses.length; i++) {
for (uint32 i = 0; i < attestationsPayloads.length; i++) {
runModules(modulesAddresses, attestationsPayloads[i], validationPayloads[i], 0);
}
}
Expand Down

0 comments on commit 6b1d978

Please sign in to comment.