fixed review comments

Consensys · Nov 26, 2024 · 63f2dc7 · 63f2dc7
1 parent d5e6353
commit 63f2dc7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/contracts/src/PortalRegistry.sol b/contracts/src/PortalRegistry.sol
@@ -195,7 +195,7 @@ contract PortalRegistry is OwnableUpgradeable {
    * @param description the portal description
    * @param ownerName name of this portal's owner
    */
-  function deployDefaultPortalV2(
+  function deployDefaultPortal(
     address[] calldata modules,
     string calldata name,
     string calldata description,

diff --git a/contracts/test/PortalRegistry.t.sol b/contracts/test/PortalRegistry.t.sol
@@ -294,21 +294,21 @@ contract PortalRegistryTest is Test {
     portalRegistry.revoke(makeAddr("randomAddress"));
   }
 
-  function test_deployDefaultPortalV2() public {
+  function test_deployDefaultPortal() public {
     CorrectModuleV2 correctModule = new CorrectModuleV2();
     address[] memory modules = new address[](1);
     modules[0] = address(correctModule);
     vm.prank(user);
-    portalRegistry.deployDefaultPortalV2(modules, expectedName, expectedDescription, true, expectedOwnerName);
+    portalRegistry.deployDefaultPortal(modules, expectedName, expectedDescription, true, expectedOwnerName);
   }
 
-  function test_deployDefaultPortalV2_OnlyAllowlisted() public {
+  function test_deployDefaultPortal_OnlyAllowlisted() public {
     CorrectModuleV2 correctModule = new CorrectModuleV2();
     address[] memory modules = new address[](1);
     modules[0] = address(correctModule);
     vm.expectRevert(PortalRegistry.OnlyAllowlisted.selector);
     vm.prank(makeAddr("InvalidUser"));
-    portalRegistry.deployDefaultPortalV2(modules, expectedName, expectedDescription, true, expectedOwnerName);
+    portalRegistry.deployDefaultPortal(modules, expectedName, expectedDescription, true, expectedOwnerName);
   }
 
   function test_getPortals_PortalNotRegistered() public {

diff --git a/contracts/test/integration/IssuersPortal.t.sol b/contracts/test/integration/IssuersPortal.t.sol
@@ -67,7 +67,7 @@ contract IssuersPortalTest is Test {
     modules[1] = address(issuersModule);
 
     vm.recordLogs();
-    portalRegistry.deployDefaultPortalV2(modules, "IssuersPortal", "IssuersPortal description", true, "Verax");
+    portalRegistry.deployDefaultPortal(modules, "IssuersPortal", "IssuersPortal description", true, "Verax");
     Vm.Log[] memory entries = vm.getRecordedLogs();
 
     // Get the address of the Portal that was just deployed and registered