feat: support perspective name qualification #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some initial tests for perspective qualified notation.
This updates the implementation to use the notion of a "path" rather than a trio of (module, perspective, name). This should future proof us for recursive submodules, and also simply helps ensure things actually make sense.
This replaces these two constructs with a single new construct (called, helpfully, `ModuleScope`). The difference is that the new construct can describe nested trees, thus making it suitable for handling perspectives (and later submodules). At this stage, register allocation is now working again with perspectives. I've chosen to retain backwards compatibility in terms of naming with the original corset. The issue is around the naming of registers which arise from coalescing perspective columns. The names currently do not include the perspective name, and this means they can potentially clash. However, clashing is not a critical issue at this time, since it will always result in the generated Trace.java file containing a syntax error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.