Support FrArray
#243
Merged
Support FrArray
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a simple implementation of an array of field elements which is backed by a byte array. This is now working, and is consuming less memory. However, its taking roughly twice as long to execute for reasons unknown.
Time is best when using this. For short traces, it also seems like about 1.5s is spent reading the `bin` file and `1.7s` lowering. So, there are optimisations to be achieved there.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
FrArrayalong withFrByteArrayandFrElementArray. These essentially factor out data representation from the original notion of aColumn. That is an improvement structurally speaking, but there remains work to be done.