fix: Incorrect Out-of-Bounds for Padding Values #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts in place a proper notion of a bounded computation, which replaces the previously awkward notion of `MaxShift`. This also requires that every column in a trace is given a `padding` value which is used when padding that column. The value for input columns is always `0` otherwise it is computed during trace expansion. Out-of-bounds accesses on trace columns then return the padding value.
This fixes the outstanding spillage tests which were written, but not actually being used.
DavePearce
deleted the
169-incorrect-out-of-bounds-calculation-for-padding-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an outstanding issue with the handling of out-of-bounds values, allowing for the correct calculation of spillage.