Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move poseidon2 to permutation package #1353

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Dec 16, 2024

Description

We have two package std/hash and std/permutation, imo for Poseidon2 as it implements only the permutation without full hash it makes sense to move it to std/permutation package.

It is a breaking change but I guess it is fine as the package is very new.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the consolidate strengthen an existing feature label Dec 16, 2024
@ivokub ivokub self-assigned this Dec 16, 2024
@ivokub ivokub merged commit 466980d into master Dec 17, 2024
5 checks passed
@ivokub ivokub deleted the refactor/poseidon2-permutation branch December 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants