fix: NNA quotient length computation edge cases #1340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes edge cases when computing the quotient length. We compute the product length in bits and then to get the quotient length, we subtract the modulus length. But as we work over uints then if the product length is less than the modulus (for example when inputs are short, on one limb), then we get underflow which due to rolling over leads to allocating huge slices. This crashes the prover.
Also fixed a potential edge case in carry computation.
Type of change
How has this been tested?
Tested with #1339
Checklist:
golangci-lint
does not output errors locally