feat: add event subscription support on MetaMaskVirtualWallet
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alwallet fix: MetaMask Virtual Wallet to support on demand connect
…/develop Develop branch version bump
…discovery fix: Decouple Virtual Wallet Discovery in `get-starknet`
…/develop Develop branch version bump
stanleyyconsensys
changed the title
stanleyyconsensys
changed the title
MetaMaskVirtualWallet
stanleyyconsensys
changed the title
MetaMaskVirtualWallet MetaMaskVirtualWallet
khanti42
requested changes
Dec 12, 2024
packages/core/src/wallet/virtualWallets/metaMaskVirtualWallet.ts
Outdated
Show resolved
Hide resolved
packages/core/src/wallet/virtualWallets/metaMaskVirtualWallet.ts
Outdated
Show resolved
Hide resolved
packages/core/src/wallet/virtualWallets/metaMaskVirtualWallet.ts
Outdated
Show resolved
Hide resolved
packages/core/src/wallet/virtualWallets/metaMaskVirtualWallet.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to adding the
onandoffevent support into the MM virtual walletThe change includes:
onandoffsupportwallet_supportedSpecsandwallet_getPermissions, as it can be return directly from the actual walletloadWalletmethod to return the virtual wallet, rather than the swo, as the swo has already binded into the virtual wallet