Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ee-jwt-claim-id to the CLI options #530

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

StefanBratanov
Copy link
Contributor

Add the new CLI option introduced in this PR: Consensys/teku#7816

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-teku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 4:24pm

Copy link

@mjsmike62 mjsmike62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with two suggested edits.

@StefanBratanov
Copy link
Contributor Author

Reviewed with two suggested edits.

Thank you. I like the suggested edit apart from the repetition of the variable in the first sentence. Changed accordingly. What do you think?

@mjsmike62
Copy link

@StefanBratanov, I'm okay with you not using the variable in the first sentence.

@StefanBratanov StefanBratanov merged commit 7bd243e into Consensys:main Dec 19, 2023
9 checks passed
@StefanBratanov StefanBratanov deleted the ee_jwt_claim_id branch December 19, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants