Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check alphabetization of CLI options #528

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Check alphabetization of CLI options #528

merged 6 commits into from
Dec 19, 2023

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Dec 16, 2023 •
edited
Loading

Closes #524

  • Reviewed CLI options and reordered entries that may be out of place

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-teku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 6:18pm

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review December 18, 2023 17:06
@joaniefromtheblock joaniefromtheblock changed the title Alphabetize CLI Options Check Check alphabetization of CLI options Dec 18, 2023
@joaniefromtheblock
Copy link
Contributor Author

@alexandratran @mjsmike62 PTAL

alexandratran
alexandratran reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one missing backtick.

docs/reference/cli/index.md Outdated Show resolved Hide resolved
@joaniefromtheblock @alexandratran
Update docs/reference/cli/index.md
5944995 
Co-authored-by: Alexandra Tran Carrillo <[email protected]>
@joaniefromtheblock
Copy link
Contributor Author

Thanks @alexandratran. Committed your suggestion :]

alexandratran
alexandratran approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexandratran alexandratran merged commit 5dac674 into Consensys:main Dec 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alphabetize command line options
3 participants
@joaniefromtheblock @CLAassistant @alexandratran