Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for --ignore-weak-subjectivity-period-enabled #503

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

lucassaldanha
Copy link
Member

Documentation for Consensys/teku#7698

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-teku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:41pm

@alexandratran
Copy link
Contributor

@lucassaldanha
Made some edits that require review:

Questions:

  1. What's the difference between checkpoint-sync-url and initial-state?
  2. Do we recommend checkpoint sync for most users?
  3. Do you need to specify ignore-weak-subjectivity-period-enabled=true if you don't use a checkpoint state?

@lucassaldanha
Copy link
Member Author

What's the difference between checkpoint-sync-url and initial-state?

They work in a similar way (behind the scenes, we set the initial-state value based on the checkpoint-sync-url.

The main reason for using it is to be aligned with the options that other clients are using. Checkpoint sync is a common term that users often refer to when syncing their nodes.

One big difference is that initial-state also accepts a file, not just a URL.

Do we recommend checkpoint sync for most users?

Totally. This is one of the reasons why we changed the default syncing behaviour to forbid users to sync from old states (including genesis).

Do you need to specify ignore-weak-subjectivity-period-enabled=true if you don't use a checkpoint state?

Most likely yes, unless you are on some private network just starting. This is how it plays:

  1. Start a node w/o checkpoint sync URL on network X
  2. Teku will check the genesis state for network X
  3. If the state is too far behind, Teku will stop and give an error. Unless ignore-weak-subjectivity-period-enabled=true.

If you are starting your node close to the genesis time of the network, then it is possible that we are still within the weak subjectivity period, so step 3 won't fail.

However, for mainnet and all official current testnets, this won't happen because their genesis is already outside of the weak subjectivity period.

@alexandratran
Copy link
Contributor

@lucassaldanha Thanks for the thorough response. I've addressed your feedback, my only outstanding question is whether we need to update the examples on the following pages to use checkpoint-sync-url?

@lucassaldanha
Copy link
Member Author

@lucassaldanha Thanks for the thorough response. I've addressed your feedback, my only outstanding question is whether we need to update the examples on the following pages to use checkpoint-sync-url?

Hi Alexandra, yes I think it would be great to update the example on these pages to use --checkpoint-sync-url. The only thing is what checkpoint sync URL we use in the examples. Basically, we do not want to make the decision for people on what "source of truth" they should trust. Even though in practice, using an endpoint like Ethstaker's is the sensible thing to do.

So the options are:

  1. We chose a trustworthy checkpoint sync provider and use it in the examples (e.g. Ethstaker's).
  2. We use a generic endpoint as a placeholder (e.g. http://your-chosen-checkpoint-sync-url.com).

Option 1 is more friendly to users, but it is more opinionated on what endpoint to use. @benjaminion do you have some thoughts on this?

@alexandratran
Copy link
Contributor

@lucassaldanha I used the Ethstaker endpoint for the "Start Teku" page because those are clearly labelled as example commands. For the connect to Mainnet and testnet pages, I added placeholder text and linked to the reference. Also raised this issue to update the Besu pages: hyperledger/besu-docs#1451

@lucassaldanha lucassaldanha enabled auto-merge (squash) November 21, 2023 21:41
@lucassaldanha lucassaldanha merged commit 1ecc53e into Consensys:main Nov 21, 2023
9 checks passed
@lucassaldanha lucassaldanha deleted the sync-ws-period branch November 21, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants