Added the network option for voluntary-exit command #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teku ticket 7489 had an issue where this option could not be used to work around an issue in the remote spec, so it was added to voluntary-exit. It's almost the same as everywhere else, but its not defaulted to mainnet, as by default is preferred to read from the beacon-api. Also auto won't really work in this circumstance I would expect, because that's what we were trying to do by loading from the beacon-api.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexandratran
approved these changes
Sep 26, 2023
|
Am I ok to merge this? |
|
@rolfyone Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teku ticket 7489 had an issue where this option could not be used to work around an issue in the remote spec, so it was added to voluntary-exit.
It's almost the same as everywhere else, but its not defaulted to mainnet, as by default is preferred to read from the beacon-api. Also auto won't really work in this circumstance I would expect, because that's what we were trying to do by loading from the beacon-api.