remove redundant nibble traversal for extensions when verifying a proof #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The verify function of the MerklePatriciaProof.sol smart contract does not process extensions correctly.
Problem Specifics
In lines 62-65 it checks if there is an extension at pathPtr. But, since pathPtr was already incremented in line 53, it can never detect an extension.
Solution
Remove lines 62-65 since we just traverse an extension and want to check for the next nibble.