Implement expirable LRU cache and config settings for EVM calls #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce an expirable LRU cache to handle EVM call results - Adding unit testing for the expirable LRU cache with mock fake time support - Allow cache parameters (expiration times, sizes) to be set via configuration
wanliqun
changed the title
boqiu
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wanliqun)
rpc/cache/cache_eth.go line 41 at r1 (raw file):
} func Init() {
Better to rename to MustInitFromViper
wanliqun
commented
Sep 18, 2024
There was a problem hiding this comment.
Reviewable status: 8 of 11 files reviewed, 1 unresolved discussion (waiting on @boqiu)
rpc/cache/cache_eth.go line 41 at r1 (raw file):
Previously, boqiu (Bo QIU) wrote…
Better to rename to
MustInitFromViper
Done.
boqiu
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @wanliqun)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is