Hotfix srv middleware panic on missing jsonrpc id (#181)

Conflux-Chain · Mar 28, 2024 · 45ef42c · 45ef42c
1 parent a3b542a
commit 45ef42c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/rpc/server_middleware.go b/rpc/server_middleware.go
@@ -52,11 +52,13 @@ func MustInit() {
 	// cfx/eth client
 	rpc.HookHandleCallMsg(clientMiddleware)
 
-	// invalid json rpc request without `ID`
-	rpc.HookHandleCallMsg(rpc.PreventMessagesWithouID)
-
 	// uniform human-readable error message
 	rpc.HookHandleCallMsg(middlewares.UniformError)
+
+	// invalid json rpc request without `ID`
+	// !!! This should always be checked at first as we might suffer nil pointer panic due to
+	// missing jsonrpc `ID` for following middleware executions.
+	rpc.HookHandleCallMsg(rpc.PreventMessagesWithouID)
 }
 
 // Inject values into context for static RPC call middlewares, e.g. rate limit