Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logger configurable #1829

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Make logger configurable #1829

merged 7 commits into from
Sep 5, 2024

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Sep 4, 2024

Description

Allows providing a custom logger when embedding Conduit.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lyuboxa lyuboxa marked this pull request as ready for review September 4, 2024 19:51
@lyuboxa lyuboxa requested a review from a team as a code owner September 4, 2024 19:51
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 💋

@lovromazgon lovromazgon merged commit 35343c5 into main Sep 5, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/configurable-logger branch September 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants