Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interpreter runtime in wasm tests #1746

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

lovromazgon
Copy link
Member

Description

This increases the speed of our WASM tests by using the interpreter runtime, since most of the time in our tests is spent compiling WASM modules. It also removes the test TestRegistry_List, since it was exactly the same as the subtest List in TestRegistry_ChaosProcessor. The last thing is the reduction of workers in the runtime test from 50 to 25.

On my machine this resulted in tests in this package finishing in 1m instead of 8m 30s.

Fixes #1649

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner August 5, 2024 19:11
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@lovromazgon lovromazgon merged commit d370cd5 into main Aug 6, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/wasm-test-performance branch August 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up WASM processor tests
2 participants