Skip to content

Commit

Permalink
updates
Browse files Browse the repository at this point in the history
  • Loading branch information
hariso committed Apr 25, 2024
1 parent 002d655 commit 2bb6b27
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 6 deletions.
32 changes: 30 additions & 2 deletions docs/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,37 @@ latest Docker image which is not a nightly is tagged with `latest`.

### Update dependencies

Dependencies should be updated in the following order:
Dependencies should be updated in the order described below. The instructions
assume that this repository and the other Conduit repositories are all cloned in
the same directory.

1. https://github.com/ConduitIO/conduit-commons/

Check failure on line 23 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Bare URL used

docs/releases.md:23:4 MD034/no-bare-urls Bare URL used [Context: "https://github.com/ConduitIO/c..."] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md034.md
*
* Run `scripts/get-compare-link.sh ../conduit-commons/` to compare the latest tag and the `main` branch.

Check failure on line 24 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:24:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
* If the changes should be released/tagged, push a new tag.

Check failure on line 25 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:25:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
2. https://github.com/conduitio/conduit-connector-protocol

Check failure on line 26 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Bare URL used

docs/releases.md:26:4 MD034/no-bare-urls Bare URL used [Context: "https://github.com/conduitio/c..."] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md034.md
* Update `conduit-commons` if needed

Check failure on line 27 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:27:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
* Run `scripts/get-compare-link.sh ../conduit-connector-protocol/` to compare the latest tag and the `main` branch.

Check failure on line 28 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:28:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
* If the changes should be released/tagged, push a new tag.

Check failure on line 29 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:29:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
3. https://github.com/ConduitIO/conduit-connector-sdk

Check failure on line 30 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Bare URL used

docs/releases.md:30:4 MD034/no-bare-urls Bare URL used [Context: "https://github.com/ConduitIO/c..."] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md034.md
* Update `conduit-commons` if needed

Check failure on line 31 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:31:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
* Update `conduit-connector-protocol` if needed

Check failure on line 32 in docs/releases.md

View workflow job for this annotation

GitHub Actions / markdownlint-cli2

Unordered list style

docs/releases.md:32:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md004.md
* Run `scripts/get-compare-link.sh ../conduit-connector-sdk/` to compare the latest tag and the `main` branch.
* If the changes should be released/tagged, push a new tag.
4. https://github.com/ConduitIO/conduit-processor-sdk
* Update `conduit-commons` if needed
* Run `scripts/get-compare-link.sh ../conduit-processor-sdk/` to compare the latest tag and the `main` branch.
* If the changes should be released/tagged, push a new tag.
5. Bump the Connector SDK in all the built-in connectors: `scripts/bump-sdk-in-connectors.sh vX.Y.Z`
6. For each of the built-in connectors (file, kafka, generator, s3, postgres, log):
* Run `scripts/get-compare-link.sh ../conduit-processor-sdk/` to compare the latest tag and the `main` branch.
* If the changes should be released/tagged, push a new tag.
7. Bump the built-in connectors: `scripts/bump-builtin-connectors.sh`
8. Conduit itself
* Update `conduit-connector-sdk` if needed
* Update `conduit-processor-sdk` if needed
* Update `conduit-connector-protocol` if needed
* Update `conduit-commons` if needed
* Release Conduit (see instructions below)

## How to release a new version

Expand Down
4 changes: 2 additions & 2 deletions scripts/bump-sdk-in-connectors.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ SDK_V=$1

for conn in 'file' 'kafka' 'generator' 's3' 'postgres' 'log'
do
cd ../conduit-connector-$conn
cd ../conduit-connector-$conn || exit

echo
echo "Working on conduit-connector-$conn"
Expand All @@ -36,5 +36,5 @@ do

gh pr create --fill --head bump-sdk-version-$SDK_V

cd ../conduit
cd ../conduit || exit
done
4 changes: 2 additions & 2 deletions scripts/get-compare-link.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ cd "$1" || { echo "Failed to move into repository directory"; exit 1; }
# Fetch tags
git fetch --tags || { echo "Failed to fetch tags"; exit 1; }

# Get the latest tag
latest_tag=$(git describe --tags --abbrev=0) || { echo "Failed to get latest tag"; exit 1; }
# Get the latest tag across all branches
latest_tag=$(git describe --tags "$(git rev-list --tags --max-count=1)") || { echo "Failed to get latest tag"; exit 1; }

# Get the owner and repository name from the remote URL
repo_url=$(git config --get remote.origin.url)
Expand Down

0 comments on commit 2bb6b27

Please sign in to comment.