Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use copyloopvar linter instead of exportloopref #45

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Use copyloopvar linter instead of exportloopref #45

merged 2 commits into from
Sep 9, 2024

Conversation

lovromazgon
Copy link
Member

Description

Updates Go to 1.23 and removes deprecated linter exportloopref in favor of copyloopvar.

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner September 6, 2024 13:24
@hariso
Copy link
Contributor

hariso commented Sep 6, 2024

It looks like golangci-lint is not friend with Go 1.23: golangci/golangci-lint#4938 (check the mentioned issues).

@lovromazgon
Copy link
Member Author

Thanks for the tip @hariso, I updated golangci-lint to the latest version now, idk why dependabot didn't do that already 😢

@lovromazgon lovromazgon merged commit 9227e64 into main Sep 9, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/linter-copyloopvar branch September 9, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovromazgon @hariso @raulb