-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#23: MobileView 375px에서 420px로 확장 대응 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image가 예약어인 관계로 ImageView로 네이밍을 한다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
close #23
같이보면 좋은 이슈: ConceptBe/conceptbe-frontend#65
코드 라인 변경이 많아보이지만, package.json 이랑 스토리북을 제외하면 100줄 내외일 것 같습니다.
위 65 이슈 반영을 위해 0.4.8 버전이 이미 배포되어있는 상태입니다. 리뷰 후 수정 사항이 생기면 0.4.9 버전으로 수정하여 배포하겠습니다.
그 외 자잘한 design, type 수정합니다.
누락된 SVG, PNG 파일을 추가하고 디자인 시스템을 0.4.8 버전으로 배포합니다.
🙋🏻 More