Skip to content

Commit

Permalink
php: improvements in handling PHP server configuration
Browse files Browse the repository at this point in the history
- frontend: added the option to enable or disable the debug mode
- frontend: optimized the number of calls to the 'get_configuration()' function of the manager when rendering the php page: 1 single call instead of 6 (8 when autoscaling is enabled)
- frontend and manager: updated the default values for the configuration parameters to match the ones in PHP v 5.6
- frontend: more sensible available values for parameters (I don't think a 4 GB post size is achievable)
- frontend: fixed indentation in PhpPage.php
- manager: the initial PHP configuration contains the default values (if not, when PHP is updated, a discrepancy may appear between the default values in the ConPaaS and the ones in PHP, leading to an unwanted effect in which changing a value from the web frontend will also change other values)
- cps-tools: shortened the 'get_configuration' command to 'get_config'
- cps-tools: human readable output for the 'get_configuration' command
- uploading code using git: more informative message from the git push hook (prints the code version id of the code just pushed)
  • Loading branch information
tcrivat committed Jul 18, 2016
1 parent c43378d commit 8676df1
Show file tree
Hide file tree
Showing 6 changed files with 325 additions and 299 deletions.
3 changes: 2 additions & 1 deletion conpaas-frontend/www/js/hosting.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ conpaas.ui = (function (this_module) {
$('.deployactions').toggleClass('invisible');
});
// configuration handlers
$('#conf-maxexec, #conf-memlim, #conf-uploadmaxsize, #conf-postmaxsize').change(function() {
$('#conf-maxexec, #conf-memlim, #conf-uploadmaxsize, #conf-postmaxsize, #conf-debugmode').change(function() {
$('#saveconf').removeAttr('disabled');
});
$('#conf-disablefunctions').focus(function() {
Expand Down Expand Up @@ -230,6 +230,7 @@ conpaas.ui = (function (this_module) {
upload_max_filesize: $('#conf-uploadmaxsize').val(),
post_max_size: $('#conf-postmaxsize').val(),
disable_functions: $('#conf-disablefunctions').val(),
display_errors: $('#conf-debugmode').val(),
}};
$(event.target).attr('disabled', 'disabled');
page.updateConfiguration(params, function () {
Expand Down
1 change: 0 additions & 1 deletion conpaas-frontend/www/lib/service/php/__init__.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ public function __construct($data, $manager) {
}
}


public function getConfiguration() {
if (!$this->isReachable()) {
return null;
Expand Down
Loading

0 comments on commit 8676df1

Please sign in to comment.