Fixs code review (final class, return void type)

Comvation · Feb 14, 2020 · 8e89751 · 8e89751
1 parent c2270cb
commit 8e89751
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/features/import/cli/importing_taxonomies_from_csv_via_cli.feature b/features/import/cli/importing_taxonomies_from_csv_via_cli.feature
@@ -14,4 +14,4 @@ Feature: Importing taxonomies from csv with the command-line interface
         And I should have at least the following taxonomy codes in the database:
           | taxon1 |
           | taxon2 |
-          | taxon11 |
+          | taxon11 |
diff --git a/spec/Processor/TaxonomyProcessorSpec.php b/spec/Processor/TaxonomyProcessorSpec.php
@@ -13,7 +13,7 @@
 use Sylius\Component\Taxonomy\Factory\TaxonFactoryInterface;
 use Sylius\Component\Taxonomy\Repository\TaxonRepositoryInterface;
 
-class TaxonomyProcessorSpec extends ObjectBehavior
+final class TaxonomyProcessorSpec extends ObjectBehavior
 {
     public function let(
         TaxonFactoryInterface $taxonFactory,

diff --git a/src/DependencyInjection/Compiler/RegisterImporterPass.php b/src/DependencyInjection/Compiler/RegisterImporterPass.php
@@ -83,7 +83,7 @@ private function registerImportFormBlockEvent(ContainerBuilder $container, strin
         ;
     }
 
-    public function buildEventHookName(string $type): string
+    private function buildEventHookName(string $type): string
     {
         if (isset($this->eventHookNames[$type])) {
             return $this->eventHookNames[$type];

diff --git a/src/Resources/config/services_import_spreadsheet.yml b/src/Resources/config/services_import_spreadsheet.yml
@@ -68,4 +68,4 @@ services:
             - "%sylius.importer.fail_on_incomplete%"
             - "%sylius.importer.stop_on_failure%"
         tags:
-            - { name: sylius.importer, type: taxonomy, format: xlsx }
+            - { name: sylius.importer, type: taxonomy, format: xlsx }
diff --git a/tests/Behat/Context/CliTaxonomiesContext.php b/tests/Behat/Context/CliTaxonomiesContext.php
@@ -12,7 +12,7 @@ final class CliTaxonomiesContext extends CliBaseContext
     /**
      * @Then I should have at least the following taxonomy codes in the database:
      */
-    public function iShouldHaveAtLeastTheFollowingTaxonomyCodesInTheDatabase(TableNode $taxonomyCodes)
+    public function iShouldHaveAtLeastTheFollowingTaxonomyCodesInTheDatabase(TableNode $taxonomyCodes): void
     {
         foreach ($taxonomyCodes as $taxonomyCode) {
             $taxonomy = $this->repository->findBy(['code' => $taxonomyCode]);

diff --git a/tests/Behat/Context/TaxonomiesContext.php b/tests/Behat/Context/TaxonomiesContext.php
@@ -8,7 +8,7 @@
 use Tests\FriendsOfSylius\SyliusImportExportPlugin\Behat\Page\TaxonCreatePageInterface;
 use Webmozart\Assert\Assert;
 
-class TaxonomiesContext implements Context
+final class TaxonomiesContext implements Context
 {
     /** @var TaxonCreatePageInterface */
     private $taxonomyCreatePage;

diff --git a/tests/Behat/Page/TaxonCreatePage.php b/tests/Behat/Page/TaxonCreatePage.php
@@ -8,7 +8,7 @@
 use Sylius\Behat\Page\Admin\Taxon\CreatePage;
 use Symfony\Component\Routing\RouterInterface;
 
-class TaxonCreatePage extends CreatePage implements TaxonCreatePageInterface
+final class TaxonCreatePage extends CreatePage implements TaxonCreatePageInterface
 {
     /** @var string */
     protected $filesPath;