Accept ed25519 and other common SSH Keys #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #199 |
jabbate19
requested changes
Dec 19, 2023
jabbate19
requested changes
Mar 7, 2024
proxstar/static/js/script.js
Outdated
| @@ -223,7 +223,7 @@ $("#create-vm").click(function(){ | |||
| const max_cpu = $(this).data('max_cpu'); | |||
| const max_mem = $(this).data('max_mem'); | |||
| const max_disk = $(this).data('max_disk'); | |||
| var ssh_regex = new RegExp("ssh-rsa AAAA[0-9A-Za-z+/]+[=]{0,3}( [^@]+@[^@]+)?") | |||
| var ssh_regex = new RegExp("ssh-[a-z]+ AAAA[0-9A-Za-z+/]+[=]{0,3}( [^@]+@[^@]+)?");; | |||
There was a problem hiding this comment.
it was in the original
galenguyer
reviewed
Mar 7, 2024
| @@ -223,7 +223,7 @@ $("#create-vm").click(function(){ | |||
| const max_cpu = $(this).data('max_cpu'); | |||
| const max_mem = $(this).data('max_mem'); | |||
| const max_disk = $(this).data('max_disk'); | |||
| var ssh_regex = new RegExp("ssh-rsa AAAA[0-9A-Za-z+/]+[=]{0,3}( [^@]+@[^@]+)?") | |||
| var ssh_regex = new RegExp("ssh-[a-z0-9]+ AAAA[0-9A-Za-z+/]+[=]{0,3}( [^@]+@[^@]+)?"); | |||
There was a problem hiding this comment.
this won't match security keys created with a hardware auth key (yubikey, solokey, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#199 Here you go @jabbate19
Updated the regex expression to accept other common ssh keys besides RSA