Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Colors #6

wants to merge 1 commit into from

Conversation

jabbate19
Copy link
Contributor

image

Idk why I felt the need to do this, but I like colors in CLI

@jabbate19
Copy link
Contributor Author

Oh ffs its stacking over my other branch

Mstrodl
Mstrodl requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@Mstrodl Mstrodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes password changes. Cherry-pick your colors commit only.

@jabbate19 jabbate19 requested a review from Mstrodl March 4, 2022 17:25
Mstrodl
Mstrodl reviewed Mar 5, 2022
View reviewed changes
src/commands/list.rs Outdated Show resolved Hide resolved
@jabbate19 jabbate19 requested a review from Mstrodl March 6, 2022 22:30
Mstrodl
Mstrodl requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@Mstrodl Mstrodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see that version fixed...

Cargo.toml Outdated Show resolved Hide resolved
src/commands/list.rs Outdated Show resolved Hide resolved
@Mstrodl
Copy link
Member

Mstrodl commented Mar 22, 2022 •
edited
Loading

Please rebase this against master, 1 million commits not good

@jabbate19 jabbate19 requested a review from Mstrodl March 26, 2022 00:00
@WillNilges
Copy link
Member

Does this do anything for the ncurses UI?

WillNilges
WillNilges requested changes Mar 26, 2022
View reviewed changes
Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as mary's, plus styling.

Cargo.toml Outdated Show resolved Hide resolved
src/commands/list.rs Outdated Show resolved Hide resolved
@jabbate19 jabbate19 requested a review from WillNilges March 26, 2022 19:38
@jabbate19
Copy link
Contributor Author

For stocked slots, do you two prefer green or white? Here's an example with green

image

@jabbate19 jabbate19 force-pushed the colors branch 2 times, most recently from 486e847 to 5c6a5f1 Compare March 29, 2022 03:17
@WillNilges
Copy link
Member

Green is more fun. Use green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mstrodl Mstrodl Awaiting requested review from Mstrodl

@WillNilges WillNilges Awaiting requested review from WillNilges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jabbate19 @Mstrodl @WillNilges