Remove Python 2 support from the build system #12920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docs based on this fact. See ComplianceAsCode#12046
jan-cerny
reviewed
Jan 29, 2025
| @@ -174,11 +174,9 @@ and keep these guidelines in mind when writing new code. | |||
| * We use [Code Climate](https://codeclimate.com/quality) to help automate the checking for PEP 8 issues. | |||
| * We do make one change from PEP 8; our maximum line length is 99 characters | |||
| * Methods should be defined before they are called | |||
| * The files in the build system shall be Python 2.7 and Python 3 compatible | |||
There was a problem hiding this comment.
I think we should define the minimal Python version that we need to be compatible with.
|
Code Climate has analyzed commit 03c9afa and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Well, the project technically still does support Python 2, but we will not be making an effort to keep this up. Update the docs to reflect this.
Rationale:
See #12046