Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RHEL 8 installed regex #12908

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 27, 2025

Description:

Make the regex better fit what we are looking for.

The regex contained an error that didn't escape the . in 8.10 correctly.
@Mab879 Mab879 added this to the 0.1.76 milestone Jan 27, 2025
@jan-cerny
Copy link
Collaborator

Does it fix some issue?

Copy link

codeclimate bot commented Jan 27, 2025

Code Climate has analyzed commit 978872a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jan 28, 2025
@Mab879
Copy link
Member Author

Mab879 commented Jan 28, 2025

Does it fix some issue?

No specific issue, much more generic than RHEL 9 and RHEL 10.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run this on a RHEL 8 VM:

[root@vm-10-0-185-17 ~]# rpm -q --qf '%{VERSION}\n' redhat-release
8.10

@jan-cerny jan-cerny merged commit e876b16 into ComplianceAsCode:master Jan 29, 2025
106 of 109 checks passed
@jan-cerny jan-cerny added the RHEL8 Red Hat Enterprise Linux 8 product related. label Jan 29, 2025
@Mab879 Mab879 deleted the update_rhel_8_installed_regex branch January 29, 2025 13:21
@Mab879 Mab879 added the Infrastructure Our content build system label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system RHEL8 Red Hat Enterprise Linux 8 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants