Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules for installing pam-runtime and pam-modules to Ubuntu 24.04 #12904

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add rules for installing pam-runtime and pam-modules to Ubuntu 24.04 #12904

wants to merge 2 commits into from

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 27, 2025

Description:

  • Create rules for installing libpam-runtime and libpam-modules packages
  • Add rules to Ubuntu 24.04 CIS controls

@mpurg mpurg requested a review from a team as a code owner January 27, 2025 13:03
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 27, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 27, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dodys dodys self-assigned this Jan 27, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 27, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 27, 2025
dodys
dodys requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its is missing adding the new rules into components/pam.yml

@mpurg mpurg force-pushed the ubuntu2404_cis_5.3.1.1_5.3.1.2 branch from 1c2916f to 2d5e9a4 Compare January 27, 2025 16:27
@dodys
Copy link
Contributor

dodys commented Jan 29, 2025

/packit build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@mpurg @dodys