Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule no_nologin_in_shells #12835

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 16, 2025

Description:

  • Implement new rule no_nologin_in_shell which checks that nologin shell is not listed in /etc/shells.
  • Add rule to Ubuntu 24.04 CIS control file

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.4.3.1

mpurg added 2 commits January 16, 2025 10:46
Checks that nologin shell is not listed in /etc/shells.
Satisfies Ubuntu 24.04 CIS control 5.4.3.1
@mpurg mpurg requested a review from a team as a code owner January 16, 2025 10:14
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 16, 2025
Copy link

openshift-ci bot commented Jan 16, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 16, 2025

Code Climate has analyzed commit e0f99ac and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Jan 16, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 16, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 16, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit faae294 into ComplianceAsCode:master Jan 16, 2025
93 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants