Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes service_enabled|disabled templates #11964

Merged
merged 3 commits into from
May 8, 2024
Merged

Minor fixes service_enabled|disabled templates #11964

merged 3 commits into from
May 8, 2024

Conversation

marcusburghardt
Copy link
Member

Description:

Alignment to Style Guides with no behavior changes.

Rationale:

Better alignment to Style Guide.

@marcusburghardt marcusburghardt added the Update Template Issues or pull requests related to Templates updates. label May 7, 2024
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone May 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11964
This image was built from commit: 9f37e9a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11964

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11964 make deploy-local

@Mab879 Mab879 self-assigned this May 7, 2024
Mab879
Mab879 requested changes May 7, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change.

shared/templates/service_disabled/ansible.template Outdated Show resolved Hide resolved
@marcusburghardt marcusburghardt requested a review from Mab879 May 7, 2024 21:06
@codeclimate CodeClimate
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 9f37e9a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 11e3838 into ComplianceAsCode:master May 8, 2024
113 checks passed
@marcusburghardt marcusburghardt deleted the minor_fixes_service_templates branch May 10, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Update Template Issues or pull requests related to Templates updates.
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusburghardt @Mab879