-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP4: Fix e2e ci assertions #11961
OCP4: Fix e2e ci assertions #11961
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Looks like we're including one update for 4.13, too. |
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.13-e2e-aws-ocp4-cis-node |
@@ -116,7 +116,7 @@ rule_results: | |||
e2e-cis-node-master-file-owner-worker-service: | |||
default_result: PASS | |||
e2e-cis-node-master-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
@@ -316,7 +316,7 @@ rule_results: | |||
e2e-cis-node-worker-file-owner-worker-service: | |||
default_result: PASS | |||
e2e-cis-node-worker-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
@@ -116,7 +116,7 @@ rule_results: | |||
e2e-cis-node-master-file-owner-worker-service: | |||
default_result: PASS | |||
e2e-cis-node-master-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
@@ -316,7 +316,7 @@ rule_results: | |||
e2e-cis-node-worker-file-owner-worker-service: | |||
default_result: PASS | |||
e2e-cis-node-worker-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
@@ -197,7 +197,7 @@ rule_results: | |||
default_result: PASS | |||
result_after_remediation: PASS | |||
e2e-high-node-master-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
@@ -547,7 +547,7 @@ rule_results: | |||
default_result: NOT-APPLICABLE | |||
result_after_remediation: NOT-APPLICABLE | |||
e2e-high-node-worker-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
@@ -197,7 +197,7 @@ rule_results: | |||
default_result: PASS | |||
result_after_remediation: PASS | |||
e2e-high-node-master-file-permissions-cni-conf: | |||
default_result: FAIL | |||
default_result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still failing in the tests.
All the failed results are due to |
/test 4.13-e2e-aws-ocp4-cis-node |
/test 4.13-e2e-aws-ocp4-pci-dss-node |
Fixing expected assertion result for rule file-permissions-cni-conf and file-groupowner-ovn-db-files, file-permissions-cni-conf should pass on ocp version >= 4.15, align file-groupowner-ovn-db-files with ComplianceAsCode#11861
Change expected result of master-file-permissions-var-log-kube-audit to PASS or INCONSISTENT, nodes get INCONSISTENT because of https://bugzilla.redhat.com/show_bug.cgi?id=2001442
Code Climate has analyzed commit f32cacf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
/test 4.13-e2e-aws-ocp4-cis-node |
@@ -176,7 +176,8 @@ rule_results: | |||
e2e-pci-dss-node-master-file-permissions-scheduler-kubeconfig: | |||
default_result: PASS | |||
e2e-pci-dss-node-master-file-permissions-var-log-kube-audit: | |||
default_result: PASS | |||
# nodes get INCONSISTENT because of https://bugzilla.redhat.com/show_bug.cgi?id=2001442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - this is still present on newer releases even though the bug has been fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixing expected assertion result for rule
file-permissions-cni-conf
andfile-groupowner-ovn-db-files
,file-permissions-cni-conf
should pass on ocp version >= 4.15Align
file-groupowner-ovn-db-files
with #11861