Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4: Fix e2e ci assertions #11961

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

Vincent056
Copy link
Contributor

Fixing expected assertion result for rule file-permissions-cni-conf and file-groupowner-ovn-db-files, file-permissions-cni-conf should pass on ocp version >= 4.15

Align file-groupowner-ovn-db-files with #11861

Copy link

github-actions bot commented May 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11961
This image was built from commit: f32cacf

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11961

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11961 make deploy-local

@rhmdnd
Copy link
Collaborator

rhmdnd commented May 7, 2024

Fixing expected assertion result for rule file-permissions-cni-conf and file-groupowner-ovn-db-files, file-permissions-cni-conf should pass on ocp version >= 4.15

Looks like we're including one update for 4.13, too.

@rhmdnd
Copy link
Collaborator

rhmdnd commented May 7, 2024

/test

Copy link

openshift-ci bot commented May 7, 2024

@rhmdnd: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test 4.13-e2e-aws-ocp4-cis
  • /test 4.13-e2e-aws-ocp4-cis-node
  • /test 4.13-e2e-aws-ocp4-e8
  • /test 4.13-e2e-aws-ocp4-high
  • /test 4.13-e2e-aws-ocp4-high-node
  • /test 4.13-e2e-aws-ocp4-moderate
  • /test 4.13-e2e-aws-ocp4-moderate-node
  • /test 4.13-e2e-aws-ocp4-pci-dss
  • /test 4.13-e2e-aws-ocp4-pci-dss-node
  • /test 4.13-e2e-aws-ocp4-stig
  • /test 4.13-e2e-aws-ocp4-stig-node
  • /test 4.13-e2e-aws-rhcos4-e8
  • /test 4.13-e2e-aws-rhcos4-high
  • /test 4.13-e2e-aws-rhcos4-moderate
  • /test 4.13-e2e-aws-rhcos4-stig
  • /test 4.13-images
  • /test 4.14-images
  • /test 4.15-e2e-aws-ocp4-cis
  • /test 4.15-e2e-aws-ocp4-cis-node
  • /test 4.15-e2e-aws-ocp4-e8
  • /test 4.15-e2e-aws-ocp4-high
  • /test 4.15-e2e-aws-ocp4-high-node
  • /test 4.15-e2e-aws-ocp4-moderate
  • /test 4.15-e2e-aws-ocp4-moderate-node
  • /test 4.15-e2e-aws-ocp4-pci-dss
  • /test 4.15-e2e-aws-ocp4-pci-dss-node
  • /test 4.15-e2e-aws-ocp4-stig
  • /test 4.15-e2e-aws-ocp4-stig-node
  • /test 4.15-e2e-aws-rhcos4-e8
  • /test 4.15-e2e-aws-rhcos4-high
  • /test 4.15-e2e-aws-rhcos4-moderate
  • /test 4.15-e2e-aws-rhcos4-stig
  • /test 4.15-images
  • /test 4.16-e2e-aws-ocp4-cis
  • /test 4.16-e2e-aws-ocp4-cis-node
  • /test 4.16-e2e-aws-ocp4-e8
  • /test 4.16-e2e-aws-ocp4-high
  • /test 4.16-e2e-aws-ocp4-high-node
  • /test 4.16-e2e-aws-ocp4-moderate
  • /test 4.16-e2e-aws-ocp4-moderate-node
  • /test 4.16-e2e-aws-ocp4-pci-dss
  • /test 4.16-e2e-aws-ocp4-pci-dss-node
  • /test 4.16-e2e-aws-ocp4-stig
  • /test 4.16-e2e-aws-ocp4-stig-node
  • /test 4.16-e2e-aws-rhcos4-e8
  • /test 4.16-e2e-aws-rhcos4-high
  • /test 4.16-e2e-aws-rhcos4-moderate
  • /test 4.16-e2e-aws-rhcos4-stig
  • /test 4.16-images
  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-4.13-images
  • pull-ci-ComplianceAsCode-content-master-4.14-images
  • pull-ci-ComplianceAsCode-content-master-4.15-images
  • pull-ci-ComplianceAsCode-content-master-4.16-images
  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link
Collaborator

rhmdnd commented May 7, 2024

/test 4.13-e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-cis-node
/test 4.16-e2e-aws-ocp4-cis-node
/test e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-high-node
/test 4.16-e2e-aws-ocp4-high-node
/test 4.15-e2e-aws-ocp4-moderate-node
/test 4.16-e2e-aws-ocp4-moderate-node
/test 4.13-e2e-aws-ocp4-pci-dss-node
/test 4.15-e2e-aws-ocp4-pci-dss-node
/test 4.16-e2e-aws-ocp4-pci-dss-node
/test e2e-aws-ocp4-pci-dss-node
/test 4.15-e2e-aws-ocp4-stig-node
/test 4.16-e2e-aws-ocp4-stig-node

@@ -116,7 +116,7 @@ rule_results:
e2e-cis-node-master-file-owner-worker-service:
default_result: PASS
e2e-cis-node-master-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@@ -316,7 +316,7 @@ rule_results:
e2e-cis-node-worker-file-owner-worker-service:
default_result: PASS
e2e-cis-node-worker-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@@ -116,7 +116,7 @@ rule_results:
e2e-cis-node-master-file-owner-worker-service:
default_result: PASS
e2e-cis-node-master-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@@ -316,7 +316,7 @@ rule_results:
e2e-cis-node-worker-file-owner-worker-service:
default_result: PASS
e2e-cis-node-worker-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@@ -197,7 +197,7 @@ rule_results:
default_result: PASS
result_after_remediation: PASS
e2e-high-node-master-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@@ -547,7 +547,7 @@ rule_results:
default_result: NOT-APPLICABLE
result_after_remediation: NOT-APPLICABLE
e2e-high-node-worker-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@@ -197,7 +197,7 @@ rule_results:
default_result: PASS
result_after_remediation: PASS
e2e-high-node-master-file-permissions-cni-conf:
default_result: FAIL
default_result: PASS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still failing in the tests.

@rhmdnd
Copy link
Collaborator

rhmdnd commented May 8, 2024

All the failed results are due to file-permissions-cni-conf being set to PASS. Otherwise, all the results look clean.

@marcusburghardt marcusburghardt added the OpenShift OpenShift product related. label May 8, 2024
@Vincent056
Copy link
Contributor Author

/test 4.13-e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-cis-node
/test 4.16-e2e-aws-ocp4-cis-node
/test e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-high-node
/test 4.16-e2e-aws-ocp4-high-node
/test 4.15-e2e-aws-ocp4-moderate-node
/test 4.16-e2e-aws-ocp4-moderate-node
/test 4.13-e2e-aws-ocp4-pci-dss-node
/test 4.15-e2e-aws-ocp4-pci-dss-node
/test 4.16-e2e-aws-ocp4-pci-dss-node
/test e2e-aws-ocp4-pci-dss-node
/test 4.15-e2e-aws-ocp4-stig-node
/test 4.16-e2e-aws-ocp4-stig-node

@yuumasato
Copy link
Member

/test 4.13-e2e-aws-ocp4-pci-dss-node

@yuumasato yuumasato self-assigned this May 8, 2024
@yuumasato yuumasato added this to the 0.1.74 milestone May 8, 2024
Fixing expected assertion result for rule file-permissions-cni-conf and file-groupowner-ovn-db-files, file-permissions-cni-conf should pass on ocp version >= 4.15, align file-groupowner-ovn-db-files with ComplianceAsCode#11861
Change expected result of master-file-permissions-var-log-kube-audit to PASS or INCONSISTENT, nodes get INCONSISTENT because of https://bugzilla.redhat.com/show_bug.cgi?id=2001442
Copy link

codeclimate bot commented May 8, 2024

Code Climate has analyzed commit f32cacf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@rhmdnd
Copy link
Collaborator

rhmdnd commented May 8, 2024

/test 4.13-e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-cis-node
/test 4.16-e2e-aws-ocp4-cis-node
/test e2e-aws-ocp4-cis-node
/test 4.15-e2e-aws-ocp4-high-node
/test 4.16-e2e-aws-ocp4-high-node
/test 4.15-e2e-aws-ocp4-moderate-node
/test 4.16-e2e-aws-ocp4-moderate-node
/test 4.13-e2e-aws-ocp4-pci-dss-node
/test 4.15-e2e-aws-ocp4-pci-dss-node
/test 4.16-e2e-aws-ocp4-pci-dss-node
/test e2e-aws-ocp4-pci-dss-node
/test 4.15-e2e-aws-ocp4-stig-node
/test 4.16-e2e-aws-ocp4-stig-node

@@ -176,7 +176,8 @@ rule_results:
e2e-pci-dss-node-master-file-permissions-scheduler-kubeconfig:
default_result: PASS
e2e-pci-dss-node-master-file-permissions-var-log-kube-audit:
default_result: PASS
# nodes get INCONSISTENT because of https://bugzilla.redhat.com/show_bug.cgi?id=2001442
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - this is still present on newer releases even though the bug has been fixed?

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 419b0fb into ComplianceAsCode:master May 8, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants