Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro clean-up #11948

Merged
Merged

Conversation

marcusburghardt
Copy link
Member

@marcusburghardt marcusburghardt commented May 6, 2024

Description:

  • Improve macros readability and description
  • Remove unused data definitions

This PR makes no changes in behavior.

Rationale:

  • Fix copy and paste issue.

It was likely copied from service_disabled template, but it is not used
or necessary in platform_service_disabled.
@marcusburghardt marcusburghardt added the Update Template Issues or pull requests related to Templates updates. label May 6, 2024
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 6, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11948
This image was built from commit: ce5fab2

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11948

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11948 make deploy-local

Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit ce5fab2 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this May 9, 2024
@jan-cerny
Copy link
Collaborator

The Code Climate issue is expected, each template preprocessing function needs to have a return statement.

@jan-cerny jan-cerny merged commit cbd4aa8 into ComplianceAsCode:master May 9, 2024
112 of 113 checks passed
@marcusburghardt marcusburghardt deleted the macro_readability branch May 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Template Issues or pull requests related to Templates updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants