Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule dconf_gnome_banner_enabled on Ubuntu #11832

Merged
merged 2 commits into from
May 8, 2024
Merged

Fix rule dconf_gnome_banner_enabled on Ubuntu #11832

merged 2 commits into from
May 8, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 17, 2024 •
edited
Loading

Description:

Allow that the gnome DoD banner is enabled also in /etc/gdm3/greeter.dconf-defaults to better align with STIG for Ubuntu 20.04/22.04 (UBTU-20-010002, UBTU-22-271010)

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11832
This image was built from commit: 50df619

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11832

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11832 make deploy-local

@mpurg mpurg force-pushed the ubuntu_2204_stig_271010 branch from f7abe9e to b40c6fd Compare April 17, 2024 08:12
@dodys dodys requested a review from a team April 17, 2024 10:54
@dodys dodys self-assigned this Apr 17, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 17, 2024
@dodys
Copy link
Contributor

dodys commented Apr 17, 2024

/packit retest-failed

@mpurg mpurg force-pushed the ubuntu_2204_stig_271010 branch from b40c6fd to c2a2133 Compare April 29, 2024 07:51
@dodys
Copy link
Contributor

dodys commented Apr 29, 2024

/packit retest-failed

@dodys
Copy link
Contributor

dodys commented May 6, 2024

/packit build

@mpurg mpurg force-pushed the ubuntu_2204_stig_271010 branch from c2a2133 to 2818369 Compare May 6, 2024 14:14
@dodys
Copy link
Contributor

dodys commented May 7, 2024

/packit build

1 similar comment
@dodys
Copy link
Contributor

dodys commented May 7, 2024

/packit build

mpurg added 2 commits May 7, 2024 14:38
@mpurg
Fix ubuntu tests for dconf_gnome_banner_enabled
ec445f2 
(cherry picked from commit e91b3552bbf2fa6d47a6f076f7ba58078aa6310b)
@mpurg
Fix rule dconf_gnome_banner_enabled on Ubuntu
50df619 
Allow that the gnome DoD banner is enabled in
/etc/gdm3/greeter.dconf-defaults to better align
with STIG for Ubuntu 20.04/22.04.
@mpurg mpurg force-pushed the ubuntu_2204_stig_271010 branch from 2818369 to 50df619 Compare May 7, 2024 12:38
@codeclimate CodeClimate
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 50df619 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit f8ae8fc into ComplianceAsCode:master May 8, 2024
112 of 113 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
3 participants
@mpurg @dodys @Mab879