Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/prometheus/client_golang to v1.20.5 - autoclosed #653

Closed

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jan 18, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/prometheus/client_golang v1.20.4 -> v1.20.5 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.5: / 2024-10-15

Compare Source

We decided to revert the testutil change that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the exact error message.

Going forward, we plan to reinforce our release testing strategy [1],[2] and deliver an enhanced testutil package/module with more flexible and safer APIs.

Thanks to @​dashpole @​dgrisonnet @​kakkoyun @​ArthurSens @​vesari @​logicalhan @​krajorama @​bwplotka who helped in this patch release! 🤗

Changelog

[BUGFIX] testutil: Reverted #​1424; functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. #​1645


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

openshift-ci bot commented Jan 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign jhrozek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 18, 2025

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:653-bdcfcf703a991f460c1529611f20517ac50769f2

@rhmdnd
Copy link

rhmdnd commented Jan 20, 2025

/test e2e-aws-parallel

@Mab879 another timeout - potentially due to openscap.

@rhmdnd rhmdnd added this to the 1.7.0 milestone Jan 20, 2025
@rhmdnd rhmdnd requested review from rhmdnd and removed request for jhrozek January 20, 2025 15:22
@rhmdnd
Copy link

rhmdnd commented Jan 21, 2025

/test e2e-aws-parallel

Hit another scan timeout - seems like we're hitting this more frequently recently?

@renovate renovate bot changed the title Update module github.com/prometheus/client_golang to v1.20.5 Update module github.com/prometheus/client_golang to v1.20.5 - autoclosed Jan 21, 2025
@renovate renovate bot closed this Jan 21, 2025
@renovate renovate bot deleted the renovate/github.com-prometheus-client_golang-1.x branch January 21, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant