Introduce a file for assertions #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhmdnd
requested review from
yuumasato and
Vincent056
and removed request for
jhrozek
We have a smattering of assertions in different files within the `framework` package. Even if you rely on your IDE to fill these in for you, organizing them is good practice. This commit adds a new file specifically for assertions, and populates it with an existing assertion used in tests. It also implements the ability for assertions to handle test outcomes, instead of returning booleans, forcing the callers to handle test outcomes. Although having test outcomes (e.g., `FailNow`) in the test is clear, we check and call `Fatal` a lot across the test code. Moving the outcome into the assertion allows the code to be a little more dry, and clear if everyone agrees assertions should accept that reponsibility.
rhmdnd
force-pushed
the
simplify-assertions
branch
from
4fee621 to
5b30875
Compare
|
🤖 To deploy this PR, run the following command: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a smattering of assertions in different files within the
frameworkpackage. Even if you rely on your IDE to fill these in foryou, organizing them is good practice.
This commit adds a new file specifically for assertions, and populates
it with an existing assertion used in tests.
It also implements the ability for assertions to handle test outcomes,
instead of returning booleans, forcing the callers to handle test
outcomes. Although having test outcomes (e.g.,
FailNow) in the test isclear, we check and call
Fatala lot across the test code. Moving theoutcome into the assertion allows the code to be a little more dry, and
clear if everyone agrees assertions should accept that reponsibility.