-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Testing section in Makefile #160
base: master
Are you sure you want to change the base?
Conversation
/retest @Vincent056 fixed up the content images for CI - so we should be good to rerun the e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
61e1fa0
to
67ce48e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like two old target names were left behind
/retest |
67ce48e
to
7d27a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test e2e-aws-parallel Failure due to issues with image registries, which is affecting more than just our project. |
7d27a76
to
6e593d7
Compare
New changes are detected. LGTM label has been removed. |
@yuumasato @Vincent056 should be ready for another review. |
🤖 To deploy this PR, run the following command:
|
This commit applies some conventions to the targets and documentation in the testing section: - Use single spaces before help text (results in shorter lines) - Add documentation for prep-e2e - Add e2e target to the testing section
6e593d7
to
c54b9a8
Compare
Dismissing review as the comments have been resolved. Thanks, Jakub!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🤖 To deploy this PR, run the following command:
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit applies some conventions to the targets and documentation in
the testing section:
Fixes #159