Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Testing section in Makefile #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Oct 18, 2022

This commit applies some conventions to the targets and documentation in
the testing section:

  • Use single spaces before help text (results in shorter lines)
  • Clarify build and push image targets for content
  • Add documentatin for prep-e2e
  • Add e2e target to the testing section
  • Fix the must-gather target by adding push-must-gather-image

Fixes #159

@rhmdnd
Copy link
Author

rhmdnd commented Oct 20, 2022

/retest

@Vincent056 fixed up the content images for CI - so we should be good to rerun the e2e tests.

Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Makefile Outdated Show resolved Hide resolved
@rhmdnd rhmdnd force-pushed the update-make-testing-section branch from 61e1fa0 to 67ce48e Compare February 6, 2023 20:32
@openshift-ci openshift-ci bot removed the lgtm label Feb 6, 2023
jhrozek
jhrozek previously requested changes Feb 7, 2023
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like two old target names were left behind

Makefile Show resolved Hide resolved
@rhmdnd
Copy link
Author

rhmdnd commented Mar 10, 2023

/retest

Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd
Copy link
Author

rhmdnd commented Aug 8, 2023

/test e2e-aws-parallel
/test e2e-aws-serial

Failure due to issues with image registries, which is affecting more than just our project.

@rhmdnd rhmdnd added this to the 1.6.1 milestone Oct 11, 2024
@rhmdnd rhmdnd force-pushed the update-make-testing-section branch from 7d27a76 to 6e593d7 Compare January 6, 2025 15:11
@openshift-ci openshift-ci bot removed the lgtm label Jan 6, 2025
Copy link

openshift-ci bot commented Jan 6, 2025

New changes are detected. LGTM label has been removed.

@rhmdnd rhmdnd modified the milestones: 1.6.1, 1.7.0 Jan 6, 2025
@rhmdnd
Copy link
Author

rhmdnd commented Jan 6, 2025

@yuumasato @Vincent056 should be ready for another review.

Copy link

github-actions bot commented Jan 6, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:160-6e593d70e8a3deac4a071236ae250c9485714307

This commit applies some conventions to the targets and documentation in
the testing section:

 - Use single spaces before help text (results in shorter lines)
 - Add documentation for prep-e2e
 - Add e2e target to the testing section
@rhmdnd rhmdnd force-pushed the update-make-testing-section branch from 6e593d7 to c54b9a8 Compare January 7, 2025 17:17
@rhmdnd rhmdnd dismissed jhrozek’s stale review January 7, 2025 17:18

Dismissing review as the comments have been resolved. Thanks, Jakub!

Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Vincent056,jhrozek,rhmdnd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Jan 7, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:160-c54b9a8f5a82a2a25e6062615afa8674b578146e

Copy link

openshift-ci bot commented Jan 7, 2025

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-parallel c54b9a8 link true /test e2e-aws-parallel
ci/prow/e2e-aws-serial c54b9a8 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make must-gather is broken
5 participants