Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hdf5 chunk scaling heuristic for bottom segments #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glennhickey
Copy link
Collaborator

There's some old logic in there that adapts the internal hdf5 chunk size relative to the size of the bottom segment (which is proportional to number of children). And now that the number of children is uncapped (#304), the chunk scaling can get to 0 for huge values (~5000?) resulting in halAppendCactusSubtree crashing with

  #000: ../../../src/H5Pdcpl.c line 2004 in H5Pset_chunk(): all chunk dimensions must be positive
    major: Invalid arguments to routine
    minor: Out of range

The fix here is to simply clamp it at 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant