Fix hdf5 chunk scaling heuristic for bottom segments #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some old logic in there that adapts the internal hdf5 chunk size relative to the size of the bottom segment (which is proportional to number of children). And now that the number of children is uncapped (#304), the chunk scaling can get to 0 for huge values (~5000?) resulting in
halAppendCactusSubtree
crashing withThe fix here is to simply clamp it at 1.