-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A animation helper that morphs between two controls #4338
Conversation
Thanks HHChaos for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
😍😍😍 |
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TransitionHelper/TransitionHelperXaml.bind
Outdated
Show resolved
Hide resolved
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Sharing some thoughts I had on if we can expose XAML helpers for this as well: <Page.Resources>
<ani:TransitionHelper x:Key="MyTransitionHelper">
<ani:AnimationConfig Id="background" Properties="Scale"/>
<ani:AnimationConfig Id="image" Properties="Scale"/>
<ani:AnimationConfig Id="guide"/>
<ani:AnimationConfig Id="name" Properties="ScaleY"/> <!-- If use flag enum then should be able to combine like "ScaleX,ScaleY" -->
<ani:AnimationConfig Id="desc"/>
</ani:TransitionHelper>
</Page.Resources>
<!-- Existing Sample Code -->
<Button x:Name="MaxToMinButton">
<interactivity:Interaction.Behaviors>
<interactions:EventTriggerBehavior EventName="Click">
<behaviors:StartTransitionAction Transition="{StaticResource MyTransitionHelper}" Source="{Binding ElementName=ThirdControl}" Target="{Binding ElementName=FirstControl}"/>
</interactions:EventTriggerBehavior>
</interactivity:Interaction.Behaviors>
</Button> Will have to dig into code more and think if we can simplify a bit further... 😉 Super excited to see how this feature can be used! Super cool. Going to mark as draft for now as we continue to explore and optimize. |
Microsoft.Toolkit.Uwp.UI.Animations/Helpers/TransitionHelper.AttachedProperty.cs
Outdated
Show resolved
Hide resolved
@HHChaos we want to move this over to Labs. Is that something you want to learn how to do, or want us to help assist with the initial migration (we can still credit the commit to your account)? Let us know, in either case, @niels9001 and I can help out here. |
Thanks @michael-hawker @niels9001 for help! It would be best if you could help with the initial migration. |
…sCommunityToolkit#4338 (Still not compiling)
…sCommunityToolkit#4338 (Still not compiling)
…sCommunityToolkit#4338 (Still not compiling)
…sCommunityToolkit#4338 (Still not compiling)
@HHChaos thanks for continuing to update this PR. 🦙❤ As discussed previously, I've moved this PR to Labs. The new PR is here: CommunityToolkit/Labs-Windows#354 Get better soon, we're all wishing you well. |
…sCommunityToolkit#4338 (Still not compiling)
…sCommunityToolkit#4338 (Still not compiling)
Feature #4323
A new animation helper that morphs between two controls was added in this PR and an example for it.
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
The document is not ready.