Clean up suppression of CS0109 #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Balkoth! I replied in the issue with more details. @Arlodotexe we need to figure out why the verbosity is bring ignored or what's ballooning the logs to where we can't see the errors in the CI easily anymore. Would be nice to be able to get at those without having to download the logs and search. |
24 tasks
|
Looks like we're not able to clean up this suppression yet. I've filed a ticket on Uno's side to see what we can do (see here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#248
PR Type
What is the current behavior?
Suppresses CS0109 on multiple occasions.
What is the new behavior?
Removed the suppresions and adjusted the code accordingly.
PR Checklist