Fix: SettingsControls UI

[0x5bfa]

Fixes

• Fix an issue where SettingsExpander's inner Grid's CornerRadius was 0px.
  
• Fix an issue where border will disapper on hovering clickable SettingsCard inside SettingsExpander
  
• Bug: Title text slightly moves up without actionable contents in narrow width #219
  

PR Type

What kind of change does this PR introduce?

• Bugfix
• Code style update (formatting)

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• Tested code with current supported SDKs
• New component
  • Documentation has been added
  • Sample in sample app has been added
  • Analyzers are passing for documentation and samples
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (if applicable)
• Header has been added to all new source files
• Contains NO breaking changes

Other information

[0x5bfa]

@dotnet-policy-service agree

[0x5bfa]

@niels9001 Since XamlStyer always style XAML every time I saved files with Ctrl+S, the diff includes formatting changes. Is it ok?

[niels9001]

@niels9001 Since XamlStyer always style XAML every time I saved files with Ctrl+S, the diff includes formatting changes. Is it ok?

Could you try and run ApplyXamlStyling.ps1 and push the changes? That should clear that up :).

Like:

cd D:\Windows .\ApplyXamlStyling.ps1 -main

[niels9001]

When setting the CornerRadius to 24, this now happens:

[niels9001]

@0x5bfa would it make sense to add a Converter here that translates the CornerRadius? E.g. a CornerRadius of 24 would be converted to 24,0,0,24?

[0x5bfa]

Yes definitely, I'd like to make it more generally so everyone can use everywhere. Thus, using ConverterParameter like 'ConverterParameter=1001' true and false combination - it means 24 0 0 24 according to the input.

[niels9001]

@0x5bfa FYI, fixed the wrapping issue here: #252

[0x5bfa]

I didn't think how troublesome styling from terminal. I'm sorry, I'm gonna close.

I hope that someone quickly fix.